Discussion:
issue/PR tips
Simon Michael
2018-10-30 00:03:43 UTC
Permalink
I've written down a first draft of advice for pull request contributors:
https://github.com/simonmichael/hledger/wiki/Pull-requests <https://github.com/simonmichael/hledger/wiki/Pull-requests>

and created a shorter pull request template referencing the above, which you should see when creating a PR

and created an issue template ("General issue"), to help steer user support questions to this list or #hledger IRC channel.

Suggestions/improvements welcome.
--
You received this message because you are subscribed to the Google Groups "hledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hledger+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Simon Michael
2018-10-30 00:11:11 UTC
Permalink
Post by Simon Michael
https://github.com/simonmichael/hledger/wiki/Pull-requests <https://github.com/simonmichael/hledger/wiki/Pull-requests>
and created a shorter pull request template referencing the above, which you should see when creating a PR
and created an issue template ("General issue"), to help steer user support questions to this list or #hledger IRC channel.
Suggestions/improvements welcome.
And by the way, not yet mentioned on that page: I am quite in favour of finding ways to improve our current github PR-based workflow. I was nodding in agreement with https://jg.gg/2018/09/29/stacked-diffs-versus-pull-requests <https://jg.gg/2018/09/29/stacked-diffs-versus-pull-requests> . I'll be looking for ways to emulate some of that - smaller units of review, less mucking about with branches and conflicts and PRs - without abandoning the conveniences of github. I have somewhere bookmarked a script that's supposed to help.
--
You received this message because you are subscribed to the Google Groups "hledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hledger+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...